Fix SSH agent forwarding to agentless nodes #22567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capnspacehook
changed the base branch from
master
to
capnspacehook/agentless-proxy-conn
capnspacehook
force-pushed
the
capnspacehook/agentless-proxy-conn
branch
from
0a84a4b to
028c938
Compare
capnspacehook
force-pushed
the
capnspacehook/agentless-agent-forwarding
branch
from
734b0c3 to
817bf94
Compare
capnspacehook
force-pushed
the
capnspacehook/agentless-agent-forwarding
branch
from
817bf94 to
8588683
Compare
jakule
reviewed
Mar 14, 2023
Contributor
jakule
left a comment
jakule
left a comment
There was a problem hiding this comment.
@capnspacehook The fix seems to work fine. Can we add some test coverage to prevent regression?
Contributor
|
@capnspacehook Ping |
When connecting to unregistered OpenSSH nodes, the SSH agent is always forwarded. When connecting to registered OpenSSH (agentless) nodes however, the SSH agent doesn't *need* to be forwarded, so only do so if the user explicitly asks to.
capnspacehook
force-pushed
the
capnspacehook/agentless-agent-forwarding
branch
from
8588683 to
790f393
Compare
capnspacehook
force-pushed
the
capnspacehook/agentless-agent-forwarding
branch
from
790f393 to
5817297
Compare
Contributor
Author
|
@jakule updated agentless integration test to test SSH agent forwarding as well. |
jakule
reviewed
Mar 20, 2023
xacrimon
approved these changes
Mar 20, 2023
Contributor
xacrimon
left a comment
xacrimon
left a comment
There was a problem hiding this comment.
lgtm once existing discussions are resolved
capnspacehook
force-pushed
the
capnspacehook/agentless-agent-forwarding
branch
from
5817297 to
f9f8820
Compare
jakule
approved these changes
Mar 21, 2023
public-teleport-github-review-bot
bot
removed the request for review
from strideynet
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #21953.
When connecting to unregistered OpenSSH nodes, the SSH agent is always
forwarded. When connecting to registered OpenSSH (agentless) nodes
however, the SSH agent doesn't need to be forwarded, so only do so
if the user explicitly asks to.